[PATCH] [PATCH] only include execinfo.h if crashtrace support is enabled

[Peter Korsgaard]

On systems without backtrace suport (E.G. uClibc depending on config),
execinfo.h might not be available, breaking the build.

Fix it by only including it if enabled.

Signed-off-by: Peter Korsgaard <jacmet-OfajU3CKLf1/***@public.gmane.org>
---
src/logging/nm-logging.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/logging/nm-logging.c b/src/logging/nm-logging.c
index ca6a709..26c8670 100644
--- a/src/logging/nm-logging.c
+++ b/src/logging/nm-logging.c
@@ -23,7 +23,6 @@

#include <dlfcn.h>
#include <syslog.h>
-#include <execinfo.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>

[Robert Schwebel]

Post by Peter Korsgaard
On systems without backtrace suport (E.G. uClibc depending on config),
execinfo.h might not be available, breaking the build.
Fix it by only including it if enabled.

But the patch just removes the include...?

rsc

Post by Peter Korsgaard
---
src/logging/nm-logging.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/logging/nm-logging.c b/src/logging/nm-logging.c
index ca6a709..26c8670 100644
--- a/src/logging/nm-logging.c
+++ b/src/logging/nm-logging.c
@@ -23,7 +23,6 @@
#include <dlfcn.h>
#include <syslog.h>
-#include <execinfo.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
--
1.7.7.1
_______________________________________________
crossdev mailing list

[Peter Korsgaard]

Post by Peter Korsgaard
On systems without backtrace suport (E.G. uClibc depending on config),
execinfo.h might not be available, breaking the build.
Fix it by only including it if enabled.

Robert> But the patch just removes the include...?

It's already included below in a conditional:

#ifdef ENABLE_CRASHTRACE
#include <execinfo.h>
#endif

[Dan Williams]

Post by Peter Korsgaard
On systems without backtrace suport (E.G. uClibc depending on config),
execinfo.h might not be available, breaking the build.
Fix it by only including it if enabled.

Applied, thanks!

Dan

Post by Peter Korsgaard
---
src/logging/nm-logging.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/src/logging/nm-logging.c b/src/logging/nm-logging.c
index ca6a709..26c8670 100644
--- a/src/logging/nm-logging.c
+++ b/src/logging/nm-logging.c
@@ -23,7 +23,6 @@
#include <dlfcn.h>
#include <syslog.h>
-#include <execinfo.h>
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>